Re: Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?
| From: | Raphael Geissert | Date: | Tue, 23 Feb 2010 01:09:40 +0000 |
| Subject: | Re: Re: why not use strtol instead of php_filter_parse_{int,hex,octal}? | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47034@lists.php.net to get a copy of this message | ||
Derick Rethans wrote:
> What exactly are you trying to fix here?
>
gcc 4.4's optimiser removes the overflow check present in
php_filter_parse_int and ZEND_HANDLE_NUMERIC (but I can't touch that part of
the code anyway...) which prevents the overflow from being detected.
Cheers,
--
Raphael Geissert