Re: Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?

From: Date: Tue, 23 Feb 2010 00:53:08 +0000
Subject: Re: Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?
References: 1 2 3 4 5  Groups: php.internals 
Request: Send a blank email to internals+get-47033@lists.php.net to get a copy of this message
On Mon, 22 Feb 2010, Raphael Geissert wrote: > Derick Rethans wrote: > > On Mon, 22 Feb 2010, Pierre Joye wrote: > >> Please don't commit this change. I remember some issues with strtol > >> (portability, BC breaks, etc.). Please wait until we figured them out, > >> or find back in the archives why strtol could be a bad idea. > > > > Poratability was indeed the reason, as well as the locale issues that > > you mention (POSIX locales==useless). Please don't commit this. > > > > Ok. Sean came up with a different patch which is being tested right now. > If all the tests pass then I'm going to commit it. What exactly are you trying to fix here? Derick -- http://derickrethans.nl | http://xdebug.org twitter: @derickr

« previous php.internals (#47033) next »