Re: Re: svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c
| From: | Derick Rethans | Date: | Tue, 25 Jan 2011 15:10:15 +0000 |
| Subject: | Re: Re: svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-51355@lists.php.net to get a copy of this message | ||
On Tue, 25 Jan 2011, Pierre Joye wrote:
> Now, as this extension is in the core and had a couple of issues that
> need to be fixed and without affecting the behavior, then I will fix
> them. Features addition or major changes will obviously need review,
> as usual.
if (! tzid)
is *not* an issue. You made it inconsistent with the rest of the code.
Stop changing it.
cheers,
Derick