Re: Re: svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

On 01/25/2011 06:37 PM, Pierre Joye wrote: > On Tue, Jan 25, 2011 at 6:03 PM, Andrey Hristov <php@hristov.com> wrote: > >> the first thing to do is to contact the extension maintainer, whoever >> this is. We have karma system and people with php-src access, however it >> is good first to contact the maintainer. On 2-3 occasions you have >> intervened in mysqlnd and broke some glass - recently broken ZTS debug >> build (which is strange because you as Win dev should build ZTS >> continously, even debug) and the other thing was the NULL logic. The >> latter broke 112 tests, it was hard to miss it, if you have tried to run >> the test suite. > > Only those doing nothing break nothing. > > Now, excuse me but I really have other things to do that defending > myself for such ridiculous arguments or discussions. > > Thanks for your support, not. > > Cheers, is it hard to miss to run the test suite? Commit without testing is a good thing, not. Best, Andrey