Re: Re: svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

On Tue, Jan 25, 2011 at 4:10 PM, Derick Rethans <derick@php.net> wrote: > On Tue, 25 Jan 2011, Pierre Joye wrote: > >> Now, as this extension is in the core and had a couple of issues that >> need to be fixed and without affecting the behavior, then I will fix >> them. Features addition or major changes will obviously need review, >> as usual. > >        if (! tzid) > > is *not* an issue. You made it inconsistent with the rest of the code. > Stop changing it. Exactly and you made it a super important problem. Where this change actually changed nothing in this code from an implementation and helped three different analyzer to identify a possible issue. But heh, who am I to make changes so the overall code quality can be improved in a more easy way. Now stop committing bad things, check return values of functions, be sure to use the right type(s), do the casting correctly and I may stop to change things, ok? Oh wait... -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org