Re: bug 54547

On 06/14/2012 10:42 PM, OISHI Kazuo wrote:

I know this was discussed a number of times here, but just to bring it to a conclusion - I intend to apply patch in the bug report - which removes conversion for strings that do not convert to integers - to 5.4. If anybody sees anything that breaks because of this please tell.

"12345678901234567890" == "12345678901234567890.0" used to be true, is now false ... i'd still say that's ok though as it is a case of "never compare floats for equality" here, now that the decimal clearly says that at least the right side is supposed to be float, not integer ...

In addition to == operator, >, <, >=, and <= operators are influenced. And, hexdecimal format for big number is now case-sensitive. http://www.mail-archive.com/internals@lists.php.net/msg58789.html

Can you add some phpt tests for all the cases you've raised? Chris -- christopher.jones@oracle.com http://twitter.com/#!/ghrd