Re: bug 54547

On 06/22/2012 12:08 AM, OISHI Kazuo wrote:

Hi,

In addition to == operator, >, <, >=, and <= operators are influenced. And, hexdecimal format for big number is now case-sensitive. http://www.mail-archive.com/internals@lists.php.net/msg58789.html

Can you add some phpt tests for all the cases you've raised?

This is the phpt. All tests passed in PHP 5.4.3 but failed in 5.4.4. (I don't know how I can add this phpt into tests.) ========================================================== --TEST-- Bug #62097: New behavior of string == has a compatibility problem (2) --FILE-- <?php var_dump("09223372036854775808" == "9223372036854775808"); var_dump(" 9223372036854775808" == "9223372036854775808"); var_dump("12345678901234567890.0" == "12345678901234567890"); var_dump("12345678901234567890e1" == "123456789012345678900"); var_dump("12345678901234567890e1" == "12345678901234567890E1"); var_dump("0xffffffffffffffff" == "0xFFFFFFFFFFFFFFFF"); var_dump("0xffffffffffffffff" > "0xFFFFFFFFFFFFFFFF"); var_dump("0xffffffffffffffff" <= "0xFFFFFFFFFFFFFFFF"); --EXPECT-- bool(true) bool(true) bool(true) bool(true) bool(true) bool(true) bool(false) bool(true) ==========================================================

Does this need an architecture specific SKIPIF? See the mention of PHP_INT_SIZE on http://qa.php.net/write-test.php I don't know whether to suggest adding an XFAIL for 5.4, or whether to suggest changing the expected output. This would depend on whether there is likely to be any code change to 5.4 or not. Chris -- christopher.jones@oracle.com http://twitter.com/#!/ghrd