Re: bug 54547

> Does this need an architecture specific SKIPIF? See the mention of > PHP_INT_SIZE on http://qa.php.net/write-test.php Like this? =============================================================== --SKIPIF-- <?php if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platforms only"); ?> =============================================================== I'm afraid I may miss your point. >>> Can you add some phpt tests for all the cases you've raised? Could you tell me your intention of this question? > I don't know whether to suggest adding an XFAIL for 5.4, or whether to > suggest changing the expected output. This would depend on whether > there is likely to be any code change to 5.4 or not. Sorry, I cannot understand what you say, but PHP code changes from 5.4.3 to 5.4.4 for #54547 and #62097 are: https://github.com/php/php-src/commit/9344bf193c6e35c8706923953f3e63bb01cc05ed https://github.com/php/php-src/commit/acd711685a592c52be200e248154283c6c49c9f8 zendi_smart_strcmp() and is_numeric_string[_ex]() are changed. -- OISHI Kazuo