Re: [RFC] Propety Accessors v1.1
| From: | Leigh | Date: | Tue, 09 Oct 2012 13:41:25 +0000 |
| Subject: | Re: [RFC] Propety Accessors v1.1 | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-63305@lists.php.net to get a copy of this message | ||
> What concerns me with the current implementation is that it leaks many
> implementation details, in particular the fact that the accessors are
> implemented as *real* __getXYZ methods and automatic implementations
> also use *real* $__XYZ properties.
Further to this, take the following example.
public $_state {
set { ... }
}
This automatically generates a "hidden" function __set_state(), which
is a magic method already (and should be declared static, and take an
array as it's only parameter)
Another fine example of how automatically generating *real*
implementations can potentially break things.