Re: Re: Regarding the latest patch on fgetcsv() (stable branch)
| From: | Rasmus Lerdorf | Date: | Fri, 12 Dec 2003 19:02:38 +0000 |
| Subject: | Re: Re: Regarding the latest patch on fgetcsv() (stable branch) | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-6364@lists.php.net to get a copy of this message | ||
On Fri, 12 Dec 2003, Ilia Alshanetsky wrote:
> That said, the whole space trimming behavior seems a little unusual since it
> will corrupt content especially if said content contains binary data. IMHO
> the data read by fgetcsv() should be fetched in such a manner so that the
> original string can be recreated.
I agree that it would be a good idea to provide a mechanism to do that,
but at this point I don't think we should be changing the behaviour of
fgetcsv() in neither the stable branch nor the HEAD branch. I'd add a new
binary-safe version of the function instead for this. Or an optional arg,
but fgetcsv() already has 2 optional args.
-Rasmus