Re: Re: Regarding the latest patch on fgetcsv() (stable branch)
| From: | Ilia Alshanetsky | Date: | Mon, 15 Dec 2003 16:03:53 +0000 |
| Subject: | Re: Re: Regarding the latest patch on fgetcsv() (stable branch) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-6476@lists.php.net to get a copy of this message | ||
On December 15, 2003 10:36 am, Moriyoshi Koizumi wrote:
> Well, the legacy users of PHP4 will significantly suffer for
> PHP5's new features.
How so? PHP 5 does break BC (especially for objects) but this is something
that was talked about for years and the consensus is/was that the change is
for the better. To my knowledge, majority of the new features in PHP5 are
just that and have no side effects.
Another alternative to moving fgetcsv()'s current implementation would be to
add #ifdef HAVE_MBSTRING around php_mblen, which would do
#define php_mblen(ptr, len) 1
if mbstring is not enabled.
Personally, I'd prefer to have the function in mbstring and modified further
to support multibyte delimiters and enclosures, which it does not do now due
to performance considerations.
Ilia