Re: Re: Regarding the latest patch on fgetcsv() (stable branch)

On December 12, 2003 02:40 pm, Moriyoshi Koizumi wrote: > I don't know why you're mentioning this at this time, > but I can say it is a sort of necessary evil :) Because the HEAD > version is capable of handling various encodings, and > less intricate IMO. Rather, I was surprised about that result, > it's only 2.5 times slower :) I mentioning this now because we are considering changes to the function in the development branch, which is a fine time to resolve any deficiencies. The added functionality, which if I understand correctly is support for multibyte delimeters and enclosures is great. But it hardly explains a significant performance disparity I am seeing. I believe much of the problem can be solved by moving from manual string iteration to one using C library functions such as memchr(). When parsing non-multibyte text there shouldn't be more then 10-15% performance loss. I should mention that benchmarks were made using time utility, so advantages offered by PHP 5's speedups were discounted. Had they been considered the speed loss would've been 300% or more. Ilia