Re: Where did the _logo_ functions go?

On 21 November 2012 14:34, Stas Malyshev <smalyshev@sugarcrm.com> wrote: >> it doesn't suit us to. I agree: in practice, I can't imagine anyone >> caring a jot about these functions being removed, but we've said that >> when we're going to remove something, we'll deprecate for a minor >> release, then remove. Why don't we live up to it? > > Exactly because in practice it is not important. Actually, I'm going to retract my statement, and here's why: http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php Let's set aside that this is terribly misguided code[0]. If that was a good enough reason to remove functionality willy-nilly, I could have saved myself a lot of e-mails on the ext/mysql front. But (to my horror) users are actually using php_logo_guid() in the wild. I haven't searched for the other functions, but I assume there are cases where they're used too. And it's not just one WordPress plugin. Nanoweb[1] calls php_logo_guid() on its demo page[2]. ErfurtWiki[3] has a similar demo page[4]. There are other projects of dubious provenance on Ohloh that call it too. It may only be a handful of projects, none of which any of us have probably ever heard of, or will ever hear a complaint from, but I bet those projects are important to their creators. > Rules are important, but it is also important to not lose the sight of > the goal - why these rules exist and when they make sense. The rules are there to protect developers from having functions dropped out from under them without warning. I don't see the problem with reverting this on the 5.5 branch only, adding E_DEPRECATED warnings to the appropriate places, and making the first item in the master UPGRADING guide for 5.6 be that these functions were removed. Adam [0] Hell, it won't even "decrypt" or "encrypt" properly on April 1, which is entertaining. [1] "The PHP Web Server": http://nanoweb.si.kz/ [2] http://nanoweb-instant.googlecode.com/svn/trunk/www/vhosts/www.cgidemo.com/index.php [3] http://sourceforge.net/projects/erfurtwiki/ [4] https://erfurtwiki.svn.sourceforge.net/svnroot/erfurtwiki/trunk/ewiki/examples/zendwiki.php