Re: Where did the _logo_ functions go?

From: Date: Wed, 21 Nov 2012 08:45:44 +0000
Subject: Re: Where did the _logo_ functions go?
References: 1 2 3 4 5 6 7 8 9 10 11 12  Groups: php.internals 
Request: Send a blank email to internals+get-64020@lists.php.net to get a copy of this message
Hi! > Actually, I'm going to retract my statement, and here's why: > > http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php I think breaking this code is an advantage :) That's definitely not how php_logo_guid should be used and using it as a secure salt makes no sense at all. To add insult to injury, it's wrapped in an if()! Please make me unsee it. > The rules are there to protect developers from having functions > dropped out from under them without warning. I know why the rules are. I just think in this case the function is clearly abused and delaying this improvement for at least a year because of somebody using logo guids as encryption salts makes no sense to me. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227

« previous php.internals (#64020) next »