Re: Where did the _logo_ functions go?
| From: | Johannes Schlüter | Date: | Wed, 21 Nov 2012 08:58:35 +0000 |
| Subject: | Re: Where did the _logo_ functions go? | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-64023@lists.php.net to get a copy of this message | ||
On Wed, 2012-11-21 at 00:45 -0800, Stas Malyshev wrote:
> Hi!
>
> > Actually, I'm going to retract my statement, and here's why:
> >
> > http://svn.wp-plugins.org/praized-community/trunk/includes/php/praized-php/PraizedCipher.php
>
> I think breaking this code is an advantage :) That's definitely not how
> php_logo_guid should be used and using it as a secure salt makes no
> sense at all. To add insult to injury, it's wrapped in an if()! Please
> make me unsee it.
Agree. We never guaranteed this to be any stable value.
And even using it to display the logo is error-prone: Whether the logo
can be shown depends on expose_php in php.ini.
johannes