Re: [RFC] Improved Linux process title support in the CLI SAPI
| From: | Keyur Govande | Date: | Fri, 08 Feb 2013 20:30:26 +0000 |
| Subject: | Re: [RFC] Improved Linux process title support in the CLI SAPI | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-65731@lists.php.net to get a copy of this message | ||
On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse <crosse@2bepublished.at>wrote:
> Hi,
>
> could you rename these functions to:
>
> cli_process_set_title
> cli_process_get_title
>
>
> http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickref<http://www.php.net/manual-lookup.php?pattern=set_&scope=quickref>
> gives me a lot of hits like:
>
> xml_parser_set_options
> stream_set_read_buffer
> pg_set_info
> ps_set_border_color
>
> etc.
>
> its also a lot more readable as it is: object_action_subject.
>
Done. In keeping with "object_action_subject" as suggested by Christoph, I
renamed the methods: cli_(get/set)_process_title. Patch updated:
https://gist.github.com/keyurdg/4728770
Since there's consensus around this, I'm moving this RFC to voting state.