Re: String Size Refactor Progress
| From: | Christopher Jones | Date: | Wed, 03 Jul 2013 18:17:13 +0000 |
| Subject: | Re: String Size Refactor Progress | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68053@lists.php.net to get a copy of this message | ||
On 07/03/2013 07:12 AM, Anthony Ferrara wrote:
Then, I defined a series of new types: #ifdef ZEND_USE_LEGACY_STRING_TYPES
Due to a problem with zend_parse_parameters, I added two new identifiers: S
and P. They act just like s and p, except that they return zend_str_size
instead of int.
When --enable-zstrlen is not enabled, I disable s and p, and changed ZPP
to rase an E_ERROR on unknown parameter types. The E_ERROR change is not
intended to go into production, but instead just makes life A LOT easier
refactoring modules one at a time.
Can you elaborate on the "problem"? Ideally the return type of s & p would
be toggled by ZEND_USE_LEGACY_STRING_TYPES.
Chris
--
christopher.jones@oracle.com http://twitter.com/ghrd
Free PHP & Oracle book:
http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html