Re: String Size Refactor Progress
| From: | Pierre Joye | Date: | Thu, 04 Jul 2013 04:56:21 +0000 |
| Subject: | Re: String Size Refactor Progress | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68066@lists.php.net to get a copy of this message | ||
Hi Yasuo,
On Jul 4, 2013 5:54 AM, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:
>
> Hi Anthony,
>
> 2013/7/3 Anthony Ferrara <ircmaxell@gmail.com>
>
> > I've migrated php_pcre.c over, but pcrelib still uses int for string
sizes.
> > This is going to be a much larger refactor, and I wanted to see people's
> > thoughts prior to digging into it.
> >
>
> For upgradability and compatibility, bundled pcrelib should be left as
> it is. Instead, checking possible over/under flow before passes string is
> better.
Or ask pcre to use size_t as well for their next major version.
Cheers,
Pierre