Re: String Size Refactor Progress
| From: | Yasuo Ohgaki | Date: | Thu, 04 Jul 2013 03:53:56 +0000 |
| Subject: | Re: String Size Refactor Progress | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-68065@lists.php.net to get a copy of this message | ||
Hi Anthony,
2013/7/3 Anthony Ferrara <ircmaxell@gmail.com>
> I've migrated php_pcre.c over, but pcrelib still uses int for string sizes.
> This is going to be a much larger refactor, and I wanted to see people's
> thoughts prior to digging into it.
>
For upgradability and compatibility, bundled pcrelib should be left as
it is. Instead, checking possible over/under flow before passes string is
better.
Most pre-complied systems use system's preclib, I suppose.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net