Re: [RFC] [Vote] Keywords as identifiers
| From: | Stas Malyshev | Date: | Tue, 22 Oct 2013 20:35:11 +0000 |
| Subject: | Re: [RFC] [Vote] Keywords as identifiers | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-69781@lists.php.net to get a copy of this message | ||
Hi!
> Just to explain why I voted "no". I think the idea is good, but what I
> see from the patch is that it adds a *lot* of hand written state
> machines which are going to be a pain to maintain. I do not think this
> extra maintenance is worth the features - we've done pretty well without
> it.
Exactly the same here. I love the idea, but looking at the code I
realize even with my experience about what's going on in the engine I
have hard time understanding what's going on there, and we're not
talking about some obscure nook of the engine - parser is right in the
middle of everything. So I personally adding so much complexity is not
worth the cost. If we can find a solution to do the same (or roughly the
same, sacrificing some less important features) without adding so much
complexity it'd be much better I think.
Maybe if you made a good narrative explanation what's going on in that
code and it turned out it's not as bad as it looks and we just didn't
realize it, it would be more acceptable.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227