Re: func_get_args BC break
| From: | Dmitry Stogov | Date: | Mon, 09 Dec 2013 06:45:59 +0000 |
| Subject: | Re: func_get_args BC break | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-70542@lists.php.net to get a copy of this message | ||
Hi,
I agree that the change makes BC break for some tricky code :(
and i don't insist to keep it in 5.5.
Thanks. Dmitry.
On Mon, Dec 9, 2013 at 4:26 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:
> Hi!
>
> Can we do anything to fix it? Is the problem limited only to
> pass-object-by-ref or also for other by-ref scenarios? In the latter
> case it does constitute a BC break I think and it may be a good idea to
> move it to 5.6...
>
>
> -------- Original Message --------
> Subject: [PHP-DEV] func_get_args BC break
> Date: Sat, 7 Dec 2013 06:15:51 -0600
> From: Nikita Popov <nikita.ppv@gmail.com>
> To: PHP internals <internals@lists.php.net>
>
> Hi internals!
>
> The performance optimizations to func_get_args that were introduced in PHP
> 5.5.6 break BC for call_user_func_array on functions with by-ref args, see
> https://bugs.php.net/bug.php?id=66107.
>
> While using that kind of code is wrong in the first place, this seems like
> a nasty break for a bugfix release. Maybe revert this for 5.5 and only keep
> in 5.6?
>
> Nikita
>
>
>