Re: func_get_args BC break
| From: | Dmitry Stogov | Date: | Mon, 09 Dec 2013 12:28:05 +0000 |
| Subject: | Re: func_get_args BC break | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-70548@lists.php.net to get a copy of this message | ||
Hi Pierre,
It was a performance improvement that caused that BC break.
For some reason func_get_arg() made a copy of each argument.
In case some argument is a big array it made a significant useless work
creating and filling new HashTable.
Thanks. Dmitry.
On Mon, Dec 9, 2013 at 3:10 PM, Pierre Joye <pierre.php@gmail.com> wrote:
>
> On Dec 9, 2013 8:46 AM, "Dmitry Stogov" <dmitry@zend.com> wrote:
> >
> > Hi,
> >
> > I agree that the change makes BC break for some tricky code :(
> > and i don't insist to keep it in 5.5.
>
> An old enough bug may become a feature.
>
> I am not sure it should be kept for 5.6 either. As of the last "dramatic"
> performance loss (about some string funcs), what are you referencing to
> here?
>
> Cheers,
> Pierre
>