Re: Re: [RFC] Slim POST data (was: PHP-5.6 and $HTTP_RAW_POST_DATA)

On Mon, 2013-12-09 at 15:17 +0100, Ferenc Kovacs wrote: > > > > On Sat, Dec 7, 2013 at 8:39 AM, Ferenc Kovacs <tyra3l@gmail.com> > wrote: > > > > I think it would make sense, to have an RFC > for 5.6 about introducing > > the new stream, the new ini option and and > how does it keeps userland > > BC while providing a way to opt-in for the > performance gain, and that > > it introduces an E_DEPRECATED so we can > remove the ini and the raw > > post global variable in the next major > version. > > > I think we cannot add E_DEPRECATED to the > INI-setting unless we make its > default -1... which breaks BC :p > > Also, I think two RFCs would be quite much, > but I already gave up my > renitency. > > > we could emmit the error from populate_raw_post_data > in main/php_content_types.c, telling people that the > auto population of $HTTP_RAW_POST_DATA along with the > use of always_populate_raw_post_data will go away, and > they should set always_populate_raw_post_data to -1 > and populate that variable for themself if their want > to be forward compatible (and silence the E_DEPRECATED > messages). > > > > > > Hi, > > > Any update on this? > I would be ok to merge with the PR in the current form, as it > resolves the BC issue, but if we want to remove the INI > setting in the future, then adding the E_DEPRECATED would be > important step. > Ok, I'll change that and open for votes then! Thanks, Mike