Re: [RFC] Multibyte char handling
| From: | Yasuo Ohgaki | Date: | Sat, 18 Jan 2014 00:20:06 +0000 |
| Subject: | Re: [RFC] Multibyte char handling | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-71219@lists.php.net to get a copy of this message | ||
Hi Julien,
On Sat, Jan 18, 2014 at 7:10 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Why is that an issue ?
>> We just leave it as-is , or ?
>
>
> Some users are annoyed by sloppy multilingual implementations using
> this option. There is feature request from user who want to remove
> mbstring.func_overload INI option.
>
> https://bugs.php.net/bug.php?id=65785
>
> We may extend or drop this feature. I neutral for this.
>
Since we are better to concentrate on fixing the security issue, I've
made it open issue for future releases.
I'll just add mb new functions to mbstring.func_overload INI option.
If func_overload is supported, we still needs php_mblen() for command
line output since it's not good idea to detect locale and using
internal_encoding
opens new vulnerability.
Functions that are better to use locale are
- mb_escape_shell_arg()
- mb_escape_shell_cmd()
These function may override locale by encoding parameter.
Since fgetcsv() uses locale now, we may do the same for fgetcsv() also.
The RFC is updated.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net