Re: [RFC] session_start(), read_only, lazy_write; Take 2

Hi Andrey, On Fri, Mar 28, 2014 at 6:09 PM, Andrey Andreev <narf@devilix.net> wrote: > Hi, > > On Fri, Mar 28, 2014 at 9:07 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > Hi Andrey, > > > > On Wed, Mar 26, 2014 at 8:15 PM, Andrey Andreev <narf@devilix.net> > wrote: > >> > >> Btw, another argument in merging updateTimestamp() into write() is > >> that userland implementations of it up until now have only been > >> possible by altering write(), so at least some users should be more > >> familiar with that approach. > > > > > > Component only does its jobs with good implementation. > > Session module consists of session manager, session save handler and > session > > serializer. > > > > Session manager should manage how it works. > > Session save handler should save/retrieve session data only. > > Session serializer should serialize/unserialize data only. > > > > It breaks this design with your suggestion. > > So letting save handler do the manager's job is not good. IMO. > > I don't understand how that's breaking any kind of design. Could you > elaborate? > Manager should manage how session behaves, not save handlers. It's basic principle of modular design. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net