Re: Bison 3 support for PHP 5.5
| From: | Rasmus Lerdorf | Date: | Fri, 23 May 2014 01:28:11 +0000 |
| Subject: | Re: Bison 3 support for PHP 5.5 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-74437@lists.php.net to get a copy of this message | ||
On 5/22/14, 6:01 PM, John Bafford wrote:
> Hi,
>
> I’ve submitted a PR (https://github.com/php/php-src/pull/683) to add support for Bison 3.0 to
> PHP 5.5.
>
> I’ve run the tests on this patch, with no unexpected errors, with Bison 2.4 (minimum version
> for PHP 5.5 and 5.6), 2.7, and 3.0, with and without --enable-maintainer-zts against the current
> PHP-5.5 and (with minor changes) master branches.
Could you explain your changes a bit? You removed %pure-parser, for
example, and you shuffled globals around. This looks like more than just
adding support for Bison 3.
-Rasmus
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc