Re: Bison 3 support for PHP 5.5

On Wed, May 28, 2014 at 2:14 PM, Johannes Schlüter <johannes@schlueters.de>wrote: > On Wed, 2014-05-28 at 14:05 +0100, Jakub Zelenka wrote: > > Ooops. We don't actaully distribute tab files. Thought that we do... :) > > > > Wouldn't be better to add them to the git? What's the actual reason to > not > > to add them. The same thing we do for scanner files already. I'm not > aware > > that bison would generate some platform specific tab files...? > > We don't in git ut snapshots and releases. Git is only for developers. > Having generated files in version control is questionable as this leads > to annoyance when timestamps come out wrong they are recreated using a > different tool version and then are being committed or have conflicts > "all the time". > > That would make sense if we didn't have re2c generated files in the repo already. Anyway I see your point. Bison version varies across the systems more than re2c so the diffs in files would be more often which is not a good idea... The solution could be to stick just with one version of bison for people that want to do changes to the grammar. It should be possible fail the make phase (not configuration) when the version is different (for example empty YACC variable when the version is different and then add check to Makefile.frag or something like that). During the configuration you would just get a warning. But that's a bit off topic and just an idea that could be considered only for new major version... :) Jakub