Re: Bison 3 support for PHP 5.5
| From: | Jakub Zelenka | Date: | Wed, 28 May 2014 12:56:28 +0000 |
| Subject: | Re: Bison 3 support for PHP 5.5 | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-74569@lists.php.net to get a copy of this message | ||
On Wed, May 28, 2014 at 12:41 PM, Derick Rethans <derick@php.net> wrote:
> On Fri, 23 May 2014, Julien Pauli wrote:
>
> > That's a no-go for 5.5.
> > 5.5 is stable, 1year old (at this email date), and we should not
> > change such a thing into this stable branch.
>
> Right, but it's going to be supported for at least another year. And
> right now, on the latest Ubuntu's with only bison 3 you can't actually
> build it. Because of that, a patch like this should absolutely be
> considered.
>
Why not just disable checking of bison version in stable versions. We
distribute generated tab files and there is no point to fail the configure
step just because someone cannot create tab file. The bison is used only if
the *.y files are changed. The thing is that such change is not allowed for
stable branches anyway. In case someone really wants to play with grammar
on old branches, then he/she should be able to install a correct version of
bison. But I think that we can count number of such users on one hand.
Just disabling version check is only config change and should not be a
problem for stable branches IMHO.
We can add a proper support for bison3 to phpng. The current patch seems to
me more like a hack than a proper solution...
Thoughts?
Jakub