Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13

From: Date: Wed, 18 Jun 2014 08:15:30 +0000
Subject: Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-74973@lists.php.net to get a copy of this message
Hi! > Back then when Sebastian > proposed ReflectionClass::newInstanceWithoutConstructor() for 5.4, he > himself introduced the only userland class restriction, because as he > mentioned some internal classes would crash if instantiated without a > constructor: > http://marc.info/?l=php-internals&m=131426563418067&w=2 > And it properly considers userland classes extending internal classes as > internal, and prohibits the instantiation for such classes: > http://3v4l.org/Zp4YS Maybe we should use the same thing for serializer, i.e. ce->create_object check? > without their constructors (which would be a nice thing anyways) I don't > see any other way to fix the segfaults while keeping the ability to > instantiate any class (be that an internal class, or a class > implementing Serialize) with ease. If we add ce->create_object check, wouldn't it solve most of the problems? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227

« previous php.internals (#74973) next »