Re: Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13

On 20 June 2014 02:30, Ferenc Kovacs <tyra3l@gmail.com> wrote: > I've linked the discussion and provide a really compact summary (I think it > is too compact) at https://bugs.php.net/bug.php?id=67072 > I'm a bit indecisive about the current situation, because I think that we > should fix the root cause of these problems, but I'm also wanna make sure > that we don't totally criple phpunit-mock-objects and doctrine with a micro > release. > At the end of the day, what we need is just instantiating an object without invoking its constructor. Wouldn't it be much easier to just revert for 5.4 and 5.5 and then patching ReflectionClass#newInstanceWithoutConstructor() to just handle internal PHP classes as well? Is there a technical limitation for this? Are there security problems related to the patch that broke phpunit/doctrine? If not, can the patch simply be delayed and only applied to 5.6? If we get a stable API to instantiate objects in our way, we'd simply gradually move away from the reflection "hack" in the next point releases of doctrine/phpunit, while using unserialize() only for older versions of PHP. Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/