Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13
| From: | Julien Pauli | Date: | Tue, 29 Jul 2014 08:43:29 +0000 |
| Subject: | Re: Problems with the fix for the BC break introduced in 5.4.29 and 5.5.13 | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-76250@lists.php.net to get a copy of this message | ||
On Tue, Jul 29, 2014 at 9:48 AM, Stas Malyshev <smalyshev@sugarcrm.com>
wrote:
> Hi!
>
> > What I found *not safe*, throwing unwanted warnings hitting an
> > undesired behavior, or even segfaulting, and thus needing patch :
> > - Dom
> > - Mysqli
> > - sqlite3 (sqlite3stmt class segfaults)
>
> I've fixed all the instances of problematic behavior with no ctor that I
> could catch now. I could not reproduce problems in DOM or mysqli, so
> it'd be nice to have reproductions there. Otherwise, I think the core
> modules are fine in my tests.
>
Mmmm, I can't reproduce segfaults.
I can only hit the check messages that check the instance is correctly
constructed.
When sqlite and SPL is patched, can we say we are safe about this issue ?
For SPL, I have no deep knowledge about it, I couldn't find any bad
behavior from my tests, all seemed to check the state, but I did not
perform full 100% coverage tests.
Thanks.
Julien