Re: php interactive shell: save history on SIGINT exit
| From: | Yasuo Ohgaki | Date: | Mon, 21 Jul 2014 09:23:58 +0000 |
| Subject: | Re: php interactive shell: save history on SIGINT exit | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-75752@lists.php.net to get a copy of this message | ||
Hi all,
On Mon, Jul 21, 2014 at 6:12 PM, Dmitry Saprykin <saprykin.dmitry@gmail.com>
wrote:
> Php interactive shell saves commands history when you exit it using 'quit'.
> But it throws all you history away when you exit using Ctrl+C. It is common
> practice to save history on SIGINT exit (mysql, mongo, etc.)
>
> I would like to implement SIGINT handler for interactive shell to save
> history on Ctrl+C exit.
>
> Threre is request on bugs.php.net for this feature
> https://bugs.php.net/bug.php?id=67496.
> I have created pull request
> https://github.com/php/php-src/pull/727 but
> was advised to create RFC to discuss this change.
>
> So could you provide some feedback.
>
Isn't it nicer to treat this kind of change as simple bug fix/feature
implementation?
It's common behavior and there is no compatibility issue at all.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net