Re: php interactive shell: save history on SIGINT exit
| From: | Tjerk Meesters | Date: | Wed, 23 Jul 2014 12:54:38 +0000 |
| Subject: | Re: php interactive shell: save history on SIGINT exit | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-75955@lists.php.net to get a copy of this message | ||
On 23 Jul, 2014, at 8:38 pm, Johannes Schlüter <johannes@schlueters.de> wrote:
> On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote:
>> changed "write_history" at the end to "append_history" after
>> each cli_is_valid_code.
>> Now it is -1 line, +1 line commit and completely looks like bug fix. )
>
> Have you tested with libedit? - A quick grep on my system shows no
> append_history() call, haven't checked further, though.
Yes, compilation fails with libedit (mac):
Undefined symbols for architecture x86_64:
"_append_history", referenced from:
_readline_shell_run in readline_cli.o
>
> johannes
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>