Re: php interactive shell: save history on SIGINT exit
| From: | Dmitry Saprykin | Date: | Wed, 23 Jul 2014 13:08:42 +0000 |
| Subject: | Re: php interactive shell: save history on SIGINT exit | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-75957@lists.php.net to get a copy of this message | ||
Yes, you are right. append_history is not suitable for libedit. I left
write_history call for libedit.
On 23 July 2014 16:38, Johannes Schlüter <johannes@schlueters.de> wrote:
> On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote:
> > changed "write_history" at the end to "append_history" after
> > each cli_is_valid_code.
> > Now it is -1 line, +1 line commit and completely looks like bug fix. )
>
> Have you tested with libedit? - A quick grep on my system shows no
> append_history() call, haven't checked further, though.
>
> johannes
>
>
>