Re: RFC: Move phpng to master

On Mon, Jul 21, 2014 at 12:41 PM, Dmitry Stogov <dmitry@zend.com> wrote: > Hi Matteo, > > We have very limited forces to test everything. Once we we have bug reports > we may look into the problems and fix them. > Wouldn't it be super easy to use the HHVM team infrastructure to test a version against various PHP projects testsuites? I can't imagine it would take longer than a few hours to adjust this to PHPs needs. > > Thanks. Dmitry. > > > On Mon, Jul 21, 2014 at 2:07 PM, Matteo Beccati <php@beccati.com> wrote: > > > On 21/07/2014 11:13, Sebastian Bergmann wrote: > > > Am 21.07.2014 10:33, schrieb Zeev Suraski: > > >> Regarding Dmitry saying that phpng is an experimental branch - that > was > > a > > >> couple of months ago. It evolved, it runs apps in parity with 5.6, > and > > it's > > >> fine to move it to master right now. The alternative - developing 5.7 > > on > > >> master and creating a synchronization hell - sounds like a horrible > > course > > >> of action. > > > > > > I was not able to run PHPUnit using PHPNG at all back when it was > first > > > announced. > > > > > > I was able to run PHPUnit 4.3 (master)'s test suite using PHPNG last > > > week, btw. Only one test fails (due to a change in the output of > > > print_r() for SplObjectStorage IIRC). This tells me that there was a > lot > > > of progress :-) > > > > I have temporarily re-enabled the phpng jobs on my CI server to assess > > the current situation. > > > > I can confirm that just one test is failing with PHPUnit master. It > > seems that print_r is not displaying StdClass properties as it used to: > > > > > > > > https://revive.beccati.com/bamboo/browse/PHP-PHPUN-PHPNG-55/test/case/11800493 > > > > > > On the other hand Doctrine master can't even run the entire test suite > > due to: > > > > Fatal error: Call to a member function getConfiguration() on null in > > > > > > /home/atlassian/bamboo/xml-data/build-dir/PHP-DOCTR-PHPNG/tests/Doctrine/Tests/OrmFunctionalTestCase.php > > on line 482 > > > > (pretty sure it's not a null there: a var_dump before the call tells me > > it's an object) > > > > ºryÊmPouWÀt¨v > > Ñhttps://revive.beccati.com/bamboo/browse/PHP-DOCTR-PHPNG-52/log > > > > > > The Revive Adserver test suite fails miserably (86+ out of 274 test > > files), mostly due to errors like: > > > > > > > /home/atlassian/bamboo/xml-data/build-dir/PHP-SRC3-BUIL/Zend/zend_hash.c(1369) > > : ht=0x29c7aa8 is already destroyed > > > > and some "Call to a member function" errors on object variables that are > > mysteriously seen as null. > > > > https://revive.beccati.com/bamboo/browse/REV-LP-PNGP-64 > > > > There's lots of legacy code in there and it has proved to be useful in > > past to catch a few uncommon segmentation faults. I'm pretty sure that > > there are plenty other applications that can't work with phpng as it is > > now. > > > > To be honest I don't think we're anywhere near the point where it's safe > > to merge phpng to master. > > > > Also, one thing that might have been overlooked is that merging phpng to > > master would completely bypass the voting phase on > > https://wiki.php.net/rfc/fast_zpp > > > > > > Cheers > > -- > > Matteo Beccati > > > > Development & Consulting - http://www.beccati.com/ > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > >