Re: 64-bit integers and 64-bit string length patch is ready to be merged
| From: | Andrea Faulds | Date: | Thu, 21 Aug 2014 18:05:23 +0000 |
| Subject: | Re: 64-bit integers and 64-bit string length patch is ready to be merged | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-76762@lists.php.net to get a copy of this message | ||
On 21 Aug 2014, at 19:03, Pierre Joye <pierre.php@gmail.com> wrote:
> Now to be honest I would merge it right away. I do not see why we need to discuss that again.
> When I see how phpng got accepted without a word, time to stop arguing about such things. Merge and
> move back to code. If one thinks that one thing or another should be changed, in this patch or
> phpng, he will need to write a rfc (and not in 6 months :).
This is a trivial name change. We have only once chance to get it right since the IS_* constants are
used so, so widely. We should get it right now.
> > Forgive me if I’m wrong, but wouldn’t changing the name again just be a simple matter
> > of global find/replace?
>
> No, totally not :)
Why wouldn’t it? Could you elaborate?
--
Andrea Faulds
http://ajf.me/