Re: Annotated PHP 5->7 extension diff

Sent from my iPhone > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > Hi Rasmus, > >> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote: >> >> Having just finished porting php-memcached (with help from Xinchen) to >> PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff >> and explain why each change was made. The extension is complicated >> enough to cover most of the changes the bulk of extension authors need >> to worry about. >> >> The diff is easy enough to grab: >> >> git clone >> https://github.com/php-memcached-dev/php-memcached.git >> cd php-memcached >> git checkout php7 >> git diff master php7 >> >> It looks like this: >> >> https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > > It uses session save handler uses PS_MOD() which is legacy. > I may help to adopt PS_MOD_TIMESTAMP(). > It eliminates writes and boost session performance a lot if apps > do not update session data always. > nice，thanks btw did you bench your optimization on file handler against Wordpress? Thanks > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net