Re: Re: Annotated PHP 5->7 extension diff

Can we just use PHP7 instead of PHPNG in the wiki, that might be misleading. On 11 February 2015 at 01:03, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote: > Xinchen Hui in php.internals (Mon, 9 Feb 2015 14:49:43 +0800): > >On Mon, Feb 9, 2015 at 5:06 AM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote: > >> https://wiki.php.net/phpng-upgrading > [snip] > >> ib_link = (ibase_db_link *)zend_fetch_resource2(Z_RES_P(link_arg), > >> link_id, LE_LINK, le_link, le_plink); > >> > >> But this is only an educated guess based on looking at changes in other > >> extensions. At the moment I am struggling with the PHP7 translation of > >> this block: > >these are changes are made recently, I've updated the relates section > >in that wiki. > > Thanks. The wiki now contains my educated guess with an alternative if > you know nothing about link_arg's type. Could you apply the PHP7 changes > to ext/interbase/interbase.c as well? The Wiki is inconsistent with the > actual PHP7 sources at the moment... > > BTW, this seems to be a copy/paste error in the Wiki: > > - if (zend_hash_find(EG(class_table), Z_STRVAL_P(key),\ > Z_STRLEN_P(key)+1, (void**)&ce_ptr) == SUCCESS) { > + if ((func = zend_hash_find_ptr(ht, Z_STR_P(key))) != NULL) { > > Jan > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Reeze Xia http://reeze.cn