Re: Annotated PHP 5->7 extension diff
| From: | Xinchen Hui | Date: | Wed, 11 Feb 2015 06:27:57 +0000 |
| Subject: | Re: Annotated PHP 5->7 extension diff | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-82417@lists.php.net to get a copy of this message | ||
Hey:
On Wed, Feb 11, 2015 at 2:07 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> On Fri, Feb 6, 2015 at 10:38 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> It looks like this:
>>>
>>>
>>> https://gist.github.com/anonymous/15cbc9947edb4f0a71fd
>>>
>>
>> It uses session save handler uses PS_MOD() which is legacy.
>> I may help to adopt PS_MOD_TIMESTAMP().
>> It eliminates writes and boost session performance a lot if apps
>> do not update session data always.
>>
>
> My environment is
>
> [yohgaki@dev helm]$ rpm -q memcached
> memcached-1.4.17-3.fc21.x86_64
>
> I've just built it with current master/php7 branch and I got
>
> Without Valgrind
> =====================================================================
> FAILED TEST SUMMARY
> ---------------------------------------------------------------------
> Memcached::cas() with strange key
> [ext/memcached/tests/experimental/cas_invalid_key.phpt]
> Memcached::deleteByKey()
> [ext/memcached/tests/experimental/delete_bykey.phpt]
> Memcached::get() [ext/memcached/tests/experimental/get.phpt]
> Memcached::getByKey() with CAS
> [ext/memcached/tests/experimental/get_bykey_cas.phpt]
> Memcached::phpinfo() [ext/memcached/tests/experimental/moduleinfo.phpt]
> =====================================================================
>
> =====================================================================
> WARNED TEST SUMMARY
> ---------------------------------------------------------------------
> Memcached store, fetch & touch expired key
> [ext/memcached/tests/expire.phpt] (warn: XFAIL section but test passes)
> =====================================================================
>
> With Valgrind
> =====================================================================
> FAILED TEST SUMMARY
> ---------------------------------------------------------------------
> Memcached::cas() with strange key
> [ext/memcached/tests/experimental/cas_invalid_key.phpt]
> Memcached::deleteByKey()
> [ext/memcached/tests/experimental/delete_bykey.phpt]
> Memcached::get() [ext/memcached/tests/experimental/get.phpt]
> Memcached::getByKey() with CAS
> [ext/memcached/tests/experimental/get_bykey_cas.phpt]
> Memcached::phpinfo() [ext/memcached/tests/experimental/moduleinfo.phpt]
> =====================================================================
>
> =====================================================================
> WARNED TEST SUMMARY
> ---------------------------------------------------------------------
> Memcached store, fetch & touch expired key
> [ext/memcached/tests/expire.phpt] (warn: XFAIL section but test passes)
> =====================================================================
>
> =====================================================================
> LEAKED TEST SUMMARY
> ---------------------------------------------------------------------
> Memcached::set()/delete() UDP
> [ext/memcached/tests/experimental/get_udp.phpt]
> Memcached::setMultiByKey()
> [ext/memcached/tests/experimental/setmulti_bykey.phpt]
> Memcached::setMulti() [ext/memcached/tests/setmulti.phpt]
> =====================================================================
The fails must be know... relates to key name checking
the leaks needs to be take care, I will look into it.
anyway, these should not affects your work,
thanks
>
> If this is normal, I'll ignore them all and start adopting new save handler
> API.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
--
Xinchen Hui
@Laruence
http://www.laruence.com/