Re: zend_get_parameters_ex rework

Hi Lester, On Wed, Feb 11, 2015 at 9:43 PM, Lester Caine <lester@lsces.co.uk> wrote: > OK I've got a patch for master, but I know that the changes are not > complete! > > http://hg.lsces.org.uk/hg/php-src/rev/8ec9101f59b6 > > I've still got a question about the &string_arg on line 1.9 and if it > should be changed to a string but that change needs working through the > following code. > > Also is what I'm doing here php7 only? so should there be wrappers for a > PHP5 build? > I think we need modules for PHP5 and PHP7. They differ a lot. I think that all this leaves is all the complaints about 'NULL' and integer > initialization makes integer from pointer without a cast > and > assignment makes integer from pointer without a cast > 1.9 + if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rr", &blob_arg, &string_arg)) { I don't read the code and just curious. The "string_arg" isn't string? Why you specify "r" (resource)? Is it badly named parameter or some kind of string resource? It may be easier for you and us, if you could use github. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net