Re: zend_get_parameters_ex rework
| From: | Jan Ehrhardt | Date: | Fri, 13 Feb 2015 16:40:04 +0000 |
| Subject: | Re: zend_get_parameters_ex rework | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-82620@lists.php.net to get a copy of this message | ||
marius adrian popa in php.internals (Fri, 13 Feb 2015 17:56:28 +0200):
>On Fri, Feb 13, 2015 at 11:55 AM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
>
>>
>> https://github.com/Jan-E/php-src/commit/8c920a22ac65da485eaf3d2fd27baf2b0406116e
>>
>> Could you test that one? I did it as a sort of PHP7 exercise, but I do
>> not have Interbase running.
>
>Thanks patch looks clean and It compiles , i will start testing it
It still gives some warnings at compile time. Most of them are caused by
ib_link = (ibase_db_link *)zend_fetch_resource2_ex(IBG(default_link),\
LE_LINK, le_link, le_plink);
warning C4024: 'zend_fetch_resource2_ex' : different types for formal
and actual parameter 1. I could not find a way to fix this.
A comparable warning in interbase.c - PHP_FUNCTION(ibase_gen_id) might
be easier to solve, I see now.
Jan