Re: zend_get_parameters_ex rework

Finish the patch and i will apply , also ZEND_FETCH_RESOURCE2 must be replaced with zend_fetch_resource2 like it was done in pgsql case https://github.com/php/php-src/commit/0d4255de30314dbfa32827e044b35543b1ae5a39 On Thu, Feb 12, 2015 at 2:42 PM, Lester Caine <lester@lsces.co.uk> wrote: > On 12/02/15 11:35, Nikita Popov wrote: > > I've still got a question about the &string_arg on line 1.9 and if it > > should be changed to a string but that change needs working through > the > > following code. > > > > > > Yes, this should be changed to a string. E.g. use the 'S' zpp modifier > > and declare the variable as 'zend_string *str'. Then modify the places > > where it is used from Z_STRVAL_P(...) to str->val and Z_STRLEN_P(...) to > > str->len. > > OK that makes sense ... and I though I was on a roll, except while I can > convert one of the uses, another is feed by a zval which I then need to > convert to a zend_string, but I think I can just change b_val to > Z_STR*(b_val) but the compiler is saying that Z_STR is not defined? > > I've spent half an hour trying to dig around but not managed to find > what I should be using :( > > -- > Lester Caine - G8HFL > ----------------------------- > Contact - http://lsces.co.uk/wiki/?page=contact > L.S.Caine Electronic Services - http://lsces.co.uk > EnquirySolve - http://enquirysolve.com/ > Model Engineers Digital Workshop - http://medw.co.uk > Rainbow Digital Media - http://rainbowdigitalmedia.co.uk > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >