Re: [RFC][Discussion] In Operator
| From: | Niklas Keller | Date: | Fri, 20 Feb 2015 20:17:06 +0000 |
| Subject: | Re: [RFC][Discussion] In Operator | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-83353@lists.php.net to get a copy of this message | ||
2015-02-20 19:48 GMT+01:00 Markus Fischer <markus@fischer.name>:
> On 20.02.15 18:16, Dan Ackroyd wrote:
>> On 20 February 2015 at 12:54, Niklas Keller <me@kelunik.com> wrote:
>>> Hi internals,
>>>
>>> It would really make sense to vote on this RFC after there has been a
>>> vote on https://wiki.php.net/rfc/context_sensitive_lexer.Hp¨[ Ü,/µOü
>>> ‚
>>
>> That is an understatement:
>>
>> https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/Expr.php#L443LÏŸìTqÑײE�
>> Ä
>>
>> I don't think changing the language in a way that breaks Doctrine
>> would be feasible.
>
> I second this. I didn't immediately reply when I read this restriction
> regarding methods but it should have been obvious.
>
> IMHO this is an absolute no-go; and the contex_sensitive_lexer sounds
> reasonable but has it's own problematic areas.
>
> - Markus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
It would clearly break Doctrine in its current state if we don't get
in that context sensitive
parser, but I want to point out, that it would still be fixable by
using a magic method for that,
like it's pointed out here:
https://twitter.com/danielgsims/status/568823804849496064
Of course that would be rather hacky.
Regards, Niklas