Re: Drop Multiply VM kind support

Hey: On Fri, Mar 13, 2015 at 3:50 PM, Dmitry Stogov <dmitry@zend.com> wrote: > Hi Xinchen, > > I don't like to remove anything. I think GOTO may be made faster. It's just > not very interesting to invest into it, because CALL is more suitable. > > execute_data->opline->handler(execute_data); won't work with CALL and global > CPU registers s well :( that exactly how the problem came to my :) thanks > > Thanks. Dmitry. > > > > On Fri, Mar 13, 2015 at 7:01 AM, Xinchen Hui <laruence@php.net> wrote: >> >> Hey: >> >> We have CALL SWITCH GOTO vm kind supports for long time. >> >> And we use CALL for default. >> >> SWITCH GOTO seems useless now, and brings us some troubles while >> maintaining . >> >> And also could make some extension unable to work, like in phpdbg: >> >> PHPDBG_G(vmret) = >> execute_data->opline->handler(execute_data); >> >> >> So, maybe it's time for us to remove GOTO and SWITCH at all? >> >> thanks >> >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ > > -- Xinchen Hui @Laruence http://www.laruence.com/