Re: Drop Multiply VM kind support

Hey: On Sat, Mar 14, 2015 at 8:01 PM, Bob Weinand <bobwei9@hotmail.com> wrote: >> Am 13.03.2015 um 05:01 schrieb Xinchen Hui <laruence@php.net>: >> >> Hey: >> >> We have CALL SWITCH GOTO vm kind supports for long time. >> >> And we use CALL for default. >> >> SWITCH GOTO seems useless now, and brings us some troubles while >> maintaining . >> >> And also could make some extension unable to work, like in phpdbg: >> >> PHPDBG_G(vmret) = execute_data->opline->handler(execute_data); >> >> >> So, maybe it's time for us to remove GOTO and SWITCH at all? >> >> thanks >> >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ > > Not sure whether it's useless, I'm not exactly aware of the performance differences. > But we would have to add some proper build-time check for phpdbg whether we're in CALL > mode or not. [when you're using phpdbg on that machine, you probably aren't in a > high-performance production environment anyway.] > > (Like with a clean #error message etc.) > After the latest fix by Dmitry, there will be no need for that. because, if in non CALL mode, phpdbg won't be able to built anymore. thanks > Bob -- Xinchen Hui @Laruence http://www.laruence.com/