Re: Drop Multiply VM kind support
| From: | Bob Weinand | Date: | Sat, 14 Mar 2015 12:01:29 +0000 |
| Subject: | Re: Drop Multiply VM kind support | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-84772@lists.php.net to get a copy of this message | ||
> Am 13.03.2015 um 05:01 schrieb Xinchen Hui <laruence@php.net>:
>
> Hey:
>
> We have CALL SWITCH GOTO vm kind supports for long time.
>
> And we use CALL for default.
>
> SWITCH GOTO seems useless now, and brings us some troubles while
> maintaining .
>
> And also could make some extension unable to work, like in phpdbg:
>
> PHPDBG_G(vmret) = execute_data->opline->handler(execute_data);
>
>
> So, maybe it's time for us to remove GOTO and SWITCH at all?
>
> thanks
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
Not sure whether it's useless, I'm not exactly aware of the performance differences.
But we would have to add some proper build-time check for phpdbg whether we're in CALL mode or
not. [when you're using phpdbg on that machine, you probably aren't in a high-performance
production environment anyway.]
(Like with a clean #error message etc.)
Bob