PR 1217: Add support for upload files from buffer string in curl extenion
| From: | Alexander Moskalev | Date: | Sat, 18 Apr 2015 10:46:18 +0000 |
| Subject: | PR 1217: Add support for upload files from buffer string in curl extenion | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-85859@lists.php.net to get a copy of this message | ||
Hi all!
I have few questions for my pull request:
https://github.com/php/php-src/pull/1217
Short story: in some special cases we need to upload just created small
file(s) by CURL. For example it's autogenerated image or pdf. And libcurl
give for us this options: CURLFORM_BUFFER, CURLFORM_BUFFERPTR and
CURLFORM_BUFFERLENGTH. My request about adding this options to curl php
extension.
For basement I used class CURLFile, but can't find solution to use same
class, because this class require file name on disc parameter in
constructor. So I created new class, now it called as CURLBufferFile.
So, my questions are:
1) Can we still integrate this functionality to exists class CURLFile?
2) If no, what do you think about class name?
a) CURLBufferFile
b) CURLBuffer
c) CURLFileBuffer
d) ... other
3) What do you think about unserialization for this class?
a) Do not accept it (becouse object can contain very big file)
b) Accept
Thanks!
--
With regards, Alexander Moskalev
irker@irker.net
irker@php.net
a.moskalev@corp.badoo.com