Re: PR 1217: Add support for upload files from buffer string in curl extenion

2015-04-24 11:10 GMT+03:00 Alexander Moskalev <irker@irker.net>: > I think It same as my current pull-request - another class with duplicate > functionality and duplicate code. We save only few strings from base class > with $postname field. > What benefits we will add using inheriting from CURLFile for php > developers? > Sorry, was from mobile client. So if we will inherit from CURLFile, we can inherit setters and getters for post filename and mime type. It's OK. But also we will have inherited method "getFilename", that is not logical correct for buffer file. More correct to have another base class for both CURLFile and CURLFIleBuffer. But it so complicated for this small feature request. I think we must use one of simplest ways: new class as in my pull-request or integrate functionality to old class as described before in this thread. -- With regards, Alexander Moskalev irker@irker.net irker@php.net a.moskalev@corp.badoo.com