Re: PR 1217: Add support for upload files from buffer string in curl extenion
| From: | Alexander Moskalev | Date: | Fri, 24 Apr 2015 08:10:57 +0000 |
| Subject: | Re: PR 1217: Add support for upload files from buffer string in curl extenion | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-85939@lists.php.net to get a copy of this message | ||
I think It same as my current pull-request - another class with duplicate
functionality and duplicate code. We save only few strings from base class
with $postname field.
What benefits we will add using inheriting from CURLFile for php
developers?
пятница, 24 апреля 2015 г. пользователь Alexey Zakhlestin написал:
>
> > On 23 Apr 2015, at 14:26, Alexander Moskalev <irker@irker.net
> <javascript:;>> wrote:
> >
> > Because currently CURLFile have this constructor:
> > public __construct
> > <http://php.net/manual/en/curlfile.construct.php> (
> > string $filename [, string $mimetype [, string $postname ]] )
> >
> > And we cannot replace this arguments to avoid BC break.
>
> (Do not top-post please.)
>
> Well… We can introduce another class, which would inherit from CURLFile.
> Similar to how SplTempFileObject extends SplFileObject.
>
>
>
> А.
>
>
--
With regards, Alexander Moskalev
irker@irker.net
irker@php.net
a.moskalev@corp.badoo.com