RE: [PHP-DEV] Pull request labels handling
| From: | Anatol Belski | Date: | Wed, 27 May 2015 16:02:52 +0000 |
| Subject: | RE: [PHP-DEV] Pull request labels handling | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86404@lists.php.net to get a copy of this message | ||
Hi,
> -----Original Message-----
> From: Hannes Magnusson [mailto:hannes.magnusson@gmail.com]
> Sent: Wednesday, May 27, 2015 4:27 PM
> To: Anatol Belski
> Cc: Internals
> Subject: Re: [PHP-DEV] Pull request labels handling
>
> On Wed, May 27, 2015 at 6:29 AM, Anatol Belski <anatol.php@belski.net>
> wrote:
> > Hi,
> >
> > the PRs on github are already being labeled. Multiple labels are possible.
> > However the github ACLs lack on granularity
> >
> > https://help.github.com/articles/permission-levels-for-an-organization
> > -repos itory/ . Due to that, while being a useful feature, labeling is
> > only available for project admins or alike. Now with PHP7 such
> > labeling becomes probably even more sense as we'll need to handle BC
> > breaks and other situations which would need more testing and care. So
> > the amount of work to evaluate and review PRs will grow while the
> > "work team" probably not.
>
>
> I don't have time to work on qa.php.net/pulls and add such feature, so I
> gave Xinchen and Nikita admin rights for the organization as a workaround.
> Stas was already an admin.
>
> We did mention that if labelling is supposed to be integral part of the
> workflow this must be available for the normal karma holder and therefore
> needs to be integrated somehow.
>
So seems the idea is even older :) The question only whether people find it useful and the feature
is going to bring something. That's what we hope it would.
Regards
Anatol